Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Expand the description if it exceeds its line limit #403

Merged
merged 1 commit into from
Aug 14, 2023
Merged

[iOS] Expand the description if it exceeds its line limit #403

merged 1 commit into from
Aug 14, 2023
+15 −3

Conversation

tkhs0604
Copy link
Contributor

@tkhs0604 tkhs0604 commented Aug 10, 2023 •
edited
Loading

Issue

Overview (Required)

  • Expand the description if it exceeds its line limit
  • I could not implement it with animation, so just switched the line limit and the visibility of "read more" button
  • Recorded it by changing its line limit from 5 to 3
  • The correct wording is not 続きを見る but 続きを読む (meaning that the issue is wrong 🙏)

Links

Screenshot

video.mp4

@tkhs0604 tkhs0604 requested a review from ry-itto August 10, 2023 17:16
@tkhs0604 tkhs0604 self-assigned this Aug 10, 2023
@github-actions
Copy link

Test Results

23 tests   23 ✔️  2m 24s ⏱️
  6 suites    0 💤
  6 files      0 ❌

Results for commit 6fce8de.

ry-itto
ry-itto approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@ry-itto ry-itto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@tkhs0604 tkhs0604 merged commit 3566adb into main Aug 14, 2023
6 checks passed
@tkhs0604 tkhs0604 deleted the kenken/expand_text branch August 14, 2023 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry-itto ry-itto ry-itto approved these changes

Assignees

@tkhs0604 tkhs0604

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[iOS] Show 「続きを見る」 button only if more than 5 lines are required to show session detail
2 participants
@tkhs0604 @ry-itto